Changeset 3500

Show
Ignore:
Timestamp:
04/12/08 10:30:38 (5 months ago)
Author:
bselby
Message:

Issues with Postgres and MySQL fixed

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • peerreviewplugin/branches/2.1-toddler/codereview/CodeReviewStruct.py

    r3494 r3500  
    4343 
    4444    def save(self, db): 
    45         query = "" 
    4645        cursor = db.cursor() 
    4746        #Add information to a new database entry 
    4847        if self.IDReview == "": 
    49             query = "INSERT INTO CodeReviews (Author, Status, DateCreate, Name, Notes) VALUES('" + dbEscape(self.Author) + "', '" + dbEscape(self.Status) + "', '" + dbEscape(self.DateCreate) + "', '" + dbEscape(self.Name) + "', '" + dbEscape(self.Notes) + "')" 
    50             cursor.execute(query) 
     48            cursor.execute("INSERT INTO CodeReviews " 
     49                           "(Author, Status, DateCreate, Name, Notes) " 
     50                           "VALUES (%s, %s, %s, %s, %s)", 
     51                           (self.Author, self.Status, self.DateCreate, self.Name, self.Notes)) 
     52            self.IDReview = db.get_last_id(cursor, 'CodeReviews', 'IDReview') 
    5153            db.commit() 
    52             self.IDReview = cursor.lastrowid; 
    5354        else: 
    5455        #Update information in existing database entry 
    55             query = "UPDATE CodeReviews SET Author = '" + dbEscape(self.Author) + "', Status = '" + dbEscape(self.Status) + "', DateCreate = '" + `self.DateCreate` + "', Name = '" + dbEscape(self.Name) + "', Notes = '" + dbEscape(self.Notes) +  "' WHERE IDReview = '" + dbEscape(self.IDReview) + "'" 
    56             cursor.execute(query) 
     56            cursor.execute("UPDATE CodeReviews SET " 
     57                           "Author=%s, Status=%s, DateCreate=%s, Name=%s, Notes=%s WHERE IDReview=%s", 
     58                           (self.Author, self.Status, self.DateCreate, self.Name, self.Notes, self.IDReview)) 
    5759            db.commit() 
    5860        return self.IDReview 
    59