Ticket #2035 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

Reply to a comment does not work

Reported by: c.posluschni@web.de Assigned to: djeebus
Priority: high Component: PeerReviewPlugin
Severity: critical Keywords: Reply
Cc: Trac Release: 0.10

Description

Reply to a comment does not work in IE and Firefox.

JavaScript? Errorlog:

Error: missing ) after argument list
Sourcefile: javascript:addComment(u'25', u'16', 89)
Row: 1, Column: 12
SourceCode:
addComment(u'25', u'16', 89)

If I apply javascript:addComment(25, 16, 89) to the address bar of my browser the "Reply To Comment on Line 25" - Dialog appears.

So I suppose the change in Line 200 (Rev. 2577) caused this error.

Rev. 717 (Line 201) 

html += "<a href=\"javascript:addComment(" + LineNum + ", " + IDFile + ", " +  comment.IDComment + ")\">Reply</a></td></tr>"

Rev. 2577 (Line 200) 

html += "<a href=\"javascript:addComment(" + `LineNum` + ", " + `IDFile` + ", " +  `comment.IDComment` + ")\">Reply</a></td></tr>"

Attachments

Change History

09/11/07 11:26:36 changed by djeebus

  • status changed from new to closed.
  • resolution set to fixed.

Thanks for pointing this out! It's been taken care of, and a couple others as well. Apparently I was using the wrong method to convert from a Long to a String. Enjoy!

Add/Change #2035 (Reply to a comment does not work)




Change Properties
Action