Ticket #2667 (closed enhancement: fixed)

Opened 7 months ago

Last modified 4 weeks ago

New access permissions for viewing of the 'Management' tab and for setting of new billing dates

Reported by: fecht Assigned to: bobbysmith007
Priority: normal Component: TimingAndEstimationPlugin
Severity: minor Keywords:
Cc: Trac Release: 0.11

Description

First of all, thanks for this great plugin !

But as not everyone is comfortable with the idea that everyone who is allowed to view tickets -> REPORT_VIEW, will also able to take a look at the hours spent on tickets and so on, here a patch that provides the following additional permissions.

TIME_VIEW : required to view the reports under the 'Billing' tab TIME_ADMIN: Everything TIME_VIEW can do, plus the ability to set a new billing date (this part is still a bit crude)

One additional change: As all the other tabs in the 'mainnav' bar are lower case, I changed this also for this plugin. Hopefully, this makes it easier for renaming and/or re-ordering of tabs with: 

[mainnav]
billing.label = Billing

[trac]
mainnav = ...,billing,....

At least, it is less confusing for me this way ;-)

Attachments

TIME_VIEW_and_TIME_ADMIN.diff (2.1 kB) - added by fecht on 03/02/08 15:38:10.
patch that makes the necessary changes in webui.py@rev3290

Change History

03/02/08 15:38:10 changed by fecht

  • attachment TIME_VIEW_and_TIME_ADMIN.diff added.

patch that makes the necessary changes in webui.py@rev3290

03/03/08 10:53:04 changed by bobbysmith007

Brilliant!

Thanks for the patch, I will try to get it integrated into the next version of the plugin.

Cheers, Russ

Also, its really neat that you can change the button names from the trac.ini. I had not seen that particular feature.

03/03/08 10:55:03 changed by bobbysmith007

Just an fyi, I dont think that TIME_VIEW actually prevents this information from being available. The user can just go to each ticket individually and compile the information manually. I still think the permission is a good idea, I just want to be sure you are aware that this doesnt completely solve this problem.

03/03/08 12:04:50 changed by fecht

Yes, but with some black magic (see #2531) this is no longer a serious problem. As that hack hides those values if the appropriate settings & permissions are applied ;-)

One could probably also write an new SQL-query to that effect and get the information that way. But I suspect that those who are allowed to do and use that would usually have the appropriate permission anyway.

But yes this problem has to be addressed, and one way to do that is with the BlackMagicTicketTweaksPlugin

03/03/08 12:17:48 changed by bobbysmith007

sweet! I hadnt seen that one at all.

(follow-up: ↓ 6 ) 04/16/08 13:04:37 changed by bobbysmith007

  • status changed from new to closed.
  • resolution set to fixed.

I still want to apply this, and I am advertising it on the plugin home page, but I am not yet sure how to integrate it in such a way that it accomplishes its goals without getting in the way if you do not care.

For now I am going to close this ticket, but I will revisit the issue when I get inspired.

(in reply to: ↑ 5 ) 09/10/08 08:58:47 changed by bobbysmith007

Replying to bobbysmith007:

I still want to apply this, and I am advertising it on the plugin home page, but I am not yet sure how to integrate it in such a way that it accomplishes its goals without getting in the way if you do not care. For now I am going to close this ticket, but I will revisit the issue when I get inspired.

Just wanted to let people know that I am working on a branch of the plugin that will incorporate this patch and appropriate code from black magic to make this work.

09/10/08 08:59:56 changed by bobbysmith007

This new branch is being sponsored by: Obsidian Software

Add/Change #2667 (New access permissions for viewing of the 'Management' tab and for setting of new billing dates)




Change Properties
Action