Ticket #2853 (closed defect: fixed)

Opened 3 months ago

Last modified 3 months ago

Page parsing silently fails when using quotes with the [forum:] handler

Reported by: KevinGabbert Assigned to: Blackhex
Priority: low Component: DiscussionPlugin
Severity: major Keywords:
Cc: kevin@kevingabbert.com Trac Release: 0.10

Description

I like to link to a report so I can have alternate text in a link, rather than something like: {22}

so I do the following: 

[forum:../report/22 Report name]

problem is, if you have quotes in that link, Trac blows up and FAILS to error! not rendering any text, buttons, or even the rest of the page.

Paste this scary code into your Trac. See what happens: 

[forum:../report/22 Report name with "Quotes"]

if you are editing a wiki page, the only way you can edit the page after that is if you add ?action=edit to the end of the url

This text will also break a ticket. I don't know a workaround for that, however.

I haven't tried it in a forum, but I bet that may break it too.

perhaps this is an error with Trac, but I figured I would start reporting it here.

Attachments

Change History

04/03/08 19:50:51 changed by KevinGabbert

FYI,

the following: 

[wiki:../report/21 this "is" a test]

will work without causing any problems

04/03/08 19:54:11 changed by KevinGabbert

Forgot to add this. Using plugin version tracdiscussion 0.5

04/03/08 20:22:04 changed by Blackhex

  • priority changed from high to low.
  • status changed from new to assigned.
  • severity changed from critical to major.

Yes, it's Trac issue. I'll check what does this caues with Discussion plugin in lately.

04/04/08 07:26:09 changed by Blackhex

  • status changed from assigned to closed.
  • resolution set to fixed.

First, why are you using [wiki:<name>] ir [forum:<id>] for refering to reports? There is [report:<id>] for that.

Secondly, there was a minor bug in DiscussionPlugin with that. Macro label is setted to title attribute of A element when refered forum/topic/message does not exist and this breaks validness of page. r3464 fixes this for 0.10 branch by stripping all " characters. 0.11 branch contains some local changes which are not yet finished so fix is not commited there.

Add/Change #2853 (Page parsing silently fails when using quotes with the [forum:] handler)




Change Properties
Action