Ticket #650 (closed defect: fixed)

Opened 2 years ago

Last modified 1 year ago

Does this work with 0.10dev?

Reported by: shawn Assigned to: coderanger
Priority: highest Component: PeerReviewPlugin
Severity: blocker Keywords:
Cc: Trac Release: 0.10

Description

I'm running Trac 0.10dev and having trouble installing it.

Attachments

missing_content.gif (4.7 kB) - added by sier on 09/06/06 03:57:24.
view_list.png (7.7 kB) - added by shawn on 09/11/06 10:18:59.
picklist
select_list.png (20.2 kB) - added by shawn on 09/11/06 10:19:33.
error when selected picklist
peerreview-0.10-workaround.txt (2.6 kB) - added by koji on 10/23/06 04:27:49.
some workaround to work with trac 0.10

Change History

(in reply to: ↑ description ; follow-up: ↓ 2 ) 08/31/06 05:02:40 changed by sier@itsolution.ch

  • priority changed from normal to highest.
  • severity changed from normal to blocker.

Replying to shawn:

I'm running Trac 0.10dev and having trouble installing it.

I have the same problem. Upgrading the environment doesn't work. The need tables are not created.

(in reply to: ↑ 1 ) 08/31/06 05:30:03 changed by anonymous

Replying to sier@itsolution.ch:

Replying to shawn:

I'm running Trac 0.10dev and having trouble installing it.

I have the same problem. Upgrading the environment doesn't work. The need tables are not created.

I' removed try/except in upgrade_environment(), during upgrade now is showing this error message:

Command failed: to_sql

09/01/06 09:00:04 changed by Shawn

Any good news yet?

09/01/06 10:32:17 changed by Team5_Adam

This plugin was never run or tested with 0.10. When we released version 1.0, we believe that many of the bugs were worked out with the integration with Trac 0.9. There isn't any planned further development with the plugin from the original development team.

09/01/06 12:12:35 changed by coderanger

I am looking to deploy this on 0.10 as well. If it is alright with you I would be willing to take over maintenance of a 0.10 branch.

09/04/06 19:19:59 changed by coderanger

  • owner changed from Team5 to coderanger.
  • status changed from new to assigned.

A 0.10-compatible version should be uploaded shortly.

(follow-up: ↓ 8 ) 09/04/06 20:06:46 changed by coderanger

Okay, the version in the 0.10 branch should be up and running.

09/06/06 03:57:24 changed by sier

  • attachment missing_content.gif added.

(in reply to: ↑ 7 ; follow-up: ↓ 9 ) 09/06/06 03:58:43 changed by sier

Replying to coderanger:

Okay, the version in the 0.10 branch should be up and running.

Now I can upgrade the environment. But when I select a file for review, just the mime type is showing and not the content of file. I'm using 0.10b1.

(in reply to: ↑ 8 ) 09/11/06 09:20:30 changed by shawn

Replying to sier:

Replying to coderanger:

Okay, the version in the 0.10 branch should be up and running.

Now I can upgrade the environment. But when I select a file for review, just the mime type is showing and not the content of file. I'm using 0.10b1.

i'm getting the same thing.

09/11/06 10:18:59 changed by shawn

  • attachment view_list.png added.

picklist

09/11/06 10:19:33 changed by shawn

  • attachment select_list.png added.

error when selected picklist

09/11/06 10:19:53 changed by shawn

I'm also getting the following error by clicking on the peer review picklist. See attached image.

10/23/06 04:27:49 changed by koji

  • attachment peerreview-0.10-workaround.txt added.

some workaround to work with trac 0.10

(follow-up: ↓ 12 ) 11/15/06 12:37:22 changed by anonymous

Using .10.2 -- I tried the workaround and everything, no go on creating a code review. I get:

Traceback (most recent call last):

File "/usr/lib/python2.3/site-packages/trac/web/main.py", line 387, in dispatch_request

dispatcher.dispatch(req)

File "/usr/lib/python2.3/site-packages/trac/web/main.py", line 245, in dispatch

req.display(template, content_type or 'text/html')

File "/usr/lib/python2.3/site-packages/trac/web/api.py", line 358, in display

data = self.hdf.render(template, form_token)

File "/usr/lib/python2.3/site-packages/trac/web/clearsilver.py", line 296, in render

injector.feed(template.render())

File "/var/tmp/python2.3-2.3.2-root/usr/lib/python2.3/HTMLParser.py", line 108, in feed

self.goahead(0)

File "/var/tmp/python2.3-2.3.2-root/usr/lib/python2.3/HTMLParser.py", line 148, in goahead

k = self.parse_starttag(i)

File "/var/tmp/python2.3-2.3.2-root/usr/lib/python2.3/HTMLParser.py", line 239, in parse_starttag

endpos = self.check_for_whole_start_tag(i)

File "/var/tmp/python2.3-2.3.2-root/usr/lib/python2.3/HTMLParser.py", line 314, in check_for_whole_start_tag

self.error("malformed start tag")

File "/var/tmp/python2.3-2.3.2-root/usr/lib/python2.3/HTMLParser.py", line 115, in error

raise HTMLParseError(message, self.getpos())

HTMLParseError: malformed start tag, at line 250, column 36

Any ideas?

(in reply to: ↑ 11 ) 11/15/06 12:40:00 changed by coderanger

Replying to anonymous:

Using .10.2 -- I tried the workaround and everything, no go on creating a code review. I get: HTMLParseError: malformed start tag, at line 250, column 36

As of 0.10.1, Trac validates the HTML produced by plugins. This plugin produces awful markup. At this point the whole thing should probably just be reworked from scratch for 0.11/Genshi.

11/24/06 01:35:09 changed by winnie

when I select a file for review, just the mime type is showing and not the content of file.

i'm getting the same thing. when it would be fixed?or which version could fix it? thanks!

05/30/07 06:54:01 changed by mikechml

(In [2270]) fixes #938, #1035 refs #650

Moved large portions of javascript to external files to avoid parser errors, and keep it tidy. Fixes for preview_to_hdf. Should now work with 0.10

08/17/07 17:26:18 changed by sontek

  • status changed from assigned to closed.
  • resolution set to fixed.

This is working for 0.10.4

Add/Change #650 (Does this work with 0.10dev?)




Change Properties
Action