Modify

Opened 4 years ago

Closed 9 months ago

Last modified 9 months ago

#10349 closed defect (fixed)

"Total" element on primary Version progress bar is not a link.

Reported by: Grayside Owned by: benkovsk
Priority: low Component: ExtendedVersionPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

The progress bar at the top of the extended version view page has a plain text number for the total issues, rather than a clickable link. It is very quickly noticeable even if it's not always used.

Attachments (1)

02-linkify_version_ticket_count.diff (1.9 KB) - added by benkovsk 9 months ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 3 years ago by rjollos

  • Owner changed from mestudd to rjollos
  • Status changed from new to assigned

Thank you for the report.

Changed 9 months ago by benkovsk

comment:2 follow-up: Changed 9 months ago by benkovsk

See attached patch that

  • makes the total count clickable, linking to a query selecting tickets of all comprising milestones
  • fixes version resource link in ticket queries

comment:3 Changed 9 months ago by rjollos

  • Resolution set to fixed
  • Status changed from assigned to closed

In 15067:

1.0dev: Make total element on progress bar a link

Patch by benkovsk.

Fixes #10349.

comment:4 Changed 9 months ago by rjollos

  • Owner changed from rjollos to benkovsk

comment:5 in reply to: ↑ 2 Changed 9 months ago by rjollos

Replying to benkovsk:

  • fixes version resource link in ticket queries

I didn't see any affect of this change. It would be nice if the version entries in the query results linked to the version page, but the template would need to be modified: browser:/tags/trac-1.0.9/trac/ticket/templates/query_results.html@:93#L82.

If I'm overlooking something, would you mind creating a new ticket with more details? Thanks!

Last edited 9 months ago by rjollos (previous) (diff)

comment:6 Changed 9 months ago by benkovsk

Oh, you are right. It needs to have this applied to Trac itself. I will create a ticket or patch later.

  • trac/ticket/templates/query_results.html

    diff --git a/trac/ticket/templates/query_results.html b/trac/ticket/templates/query_results.html
    index af850ec..5f91e2b 100644
    a b Arguments: 
    9191                      <py:when test="name == 'cc'">${format_emails(ticket_context, value)}</py:when>
    9292                      <py:when test="name == 'owner' and value">${authorinfo(value)}</py:when>
    9393                      <py:when test="name == 'milestone'" py:if="value">${resource_link(context, Resource('milestone', value), 'compact')}</py:when>
     94                      <py:when test="name == 'version'" py:if="value">${resource_link(context, Resource('version', value), 'compact')}</py:when>
    9495                      <py:when test="header.wikify">${wiki_to_oneliner(ticket_context, value)}</py:when>
    9596                      <py:when test="header.wikifyblock">${wiki_to_html(ticket_context, value)}</py:when>
    9697                      <py:otherwise>$value</py:otherwise>
Last edited 9 months ago by rjollos (previous) (diff)

comment:7 Changed 9 months ago by rjollos

The template would need to be modified in an ITemplateStreamFilter. It may not be worth the effort when we could instead focus on implementing trac:#1233 (see trac:comment:24:ticket:1233).

Add Comment

Modify Ticket

Action
as closed The owner will remain benkovsk.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.