Modify

Opened 11 years ago

Closed 9 years ago

Last modified 8 years ago

#10593 closed enhancement (fixed)

Template enhancement

Reported by: sdegrande Owned by: sdegrande
Priority: normal Component: DiscussionPlugin
Severity: normal Keywords:
Cc: Radek Bartoň Trac Release: 1.0

Description

I changed a bit the templates, adding some divs where needed, in order to be able to mimic the new 1.0 design :

Here is the proposed patch.

I can also upload the CSS I used (which would be to be reworked, since I'm far from being a CSS expert).

Thanks for your great work !

Attachments (4)

forum-list.png (40.4 KB) - added by sdegrande 11 years ago.
topic.png (50.1 KB) - added by sdegrande 11 years ago.
rounded_template.patch (8.3 KB) - added by sdegrande 11 years ago.
adapt_template_to_trac_new_style.patch (9.7 KB) - added by sdegrande 9 years ago.

Download all attachments as: .zip

Change History (16)

Changed 11 years ago by sdegrande

Attachment: forum-list.png added

Changed 11 years ago by sdegrande

Attachment: topic.png added

Changed 11 years ago by sdegrande

Attachment: rounded_template.patch added

comment:1 Changed 11 years ago by Ryan J Ollos

Cc: Radek Bartoň added; Ryan J Ollos removed
Owner: changed from Radek Bartoň to Ryan J Ollos

I'll keep this ticket on my radar, but I'd like to avoid forking for 1.0 until we get a few more bugs fixed. I'm not very proficient in CSS either, so it will take me a bit of time to get this committed.

comment:2 in reply to:  1 ; Changed 9 years ago by Ryan J Ollos

Status: newaccepted

Replying to rjollos:

I'll keep this ticket on my radar, but I'd like to avoid forking for 1.0 until we get a few more bugs fixed.

My future self says ... Unacceptable! Supporting old versions of Trac is a waste of time. Branch and support 1.0 and later :)

comment:3 Changed 9 years ago by Ryan J Ollos

sdegrande: would you consider rebasing this patch on the 1.0 branch so that it applies cleanly? Thanks!

comment:4 in reply to:  2 Changed 9 years ago by sdegrande

Replying to rjollos:

Replying to rjollos:

I'll keep this ticket on my radar, but I'd like to avoid forking for 1.0 until we get a few more bugs fixed.

My future self says ... Unacceptable! Supporting old versions of Trac is a waste of time. Branch and support 1.0 and later :)

Well, I think that you know my humble opinion on that point... Just move on !

Changed 9 years ago by sdegrande

comment:5 Changed 9 years ago by sdegrande

I attached a rebased version of the patch (attachment:adapt_template_to_trac_new_style.patch), also including the CSS changes to have rounded box around lists and list elements, to mimic new Trac style.

comment:6 Changed 9 years ago by Ryan J Ollos

In 14884:

0.10dev: Use equivalent functions passed in chrome dictionary. Refs #10593.

comment:7 Changed 9 years ago by Ryan J Ollos

sdegrande: You now have commit access to both the DiscussionPlugin and DownloadsPlugin. Feel free to push patches directly, or post to a ticket first if for any reason you'd like a second opinion.

comment:8 Changed 9 years ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

In 14885:

0.10dev: Better styling for Trac 1.0. Fixes #10593.

Patch by sdegrande.

comment:9 Changed 9 years ago by Ryan J Ollos

Owner: changed from Ryan J Ollos to sdegrande

comment:10 in reply to:  7 Changed 9 years ago by sdegrande

Replying to rjollos:

sdegrande: You now have commit access to both the DiscussionPlugin and DownloadsPlugin. Feel free to push patches directly, or post to a ticket first if for any reason you'd like a second opinion.

Thanks.

I do not consider myself as a good enough python coder to avoid a code review from an expert if I was to submit some 'complex changes'. So yes, I would first post a ticket.

comment:11 Changed 8 years ago by Ryan J Ollos

In 15151:

0.10dev: Implement change that was overlooked in [14884]

Refs #10593, #12640.

comment:12 Changed 8 years ago by Ryan J Ollos

In 15547:

0.10dev: Implement another change that was overlooked in [14884]

Refs #10593.
Fixes #12762.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain sdegrande.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.