Modify

Opened 4 years ago

Closed 21 months ago

Last modified 21 months ago

#11164 closed enhancement (fixed)

Package site templates after porting from ClearSilver to Genshi

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Component: TracHacksPlugin
Severity: normal Keywords: clearsilver genshi templates
Cc: Steffen Hoffmann, Odd Simon Simonsen Trac Release:

Description (last modified by Ryan J Ollos)

As osimons mentioned in comment:45:ticket:10193, the site templates need to be ported from ClearSilver to Genshi. I'll suggest that it makes sense to have TracHacksPlugin install the templates so that they'll be maintained in source control, versioned and installed as part of the package.

Attachments (0)

Change History (17)

comment:1 Changed 4 years ago by Odd Simon Simonsen

Or redo changes as streamfilters. Or redo them as a theme that includes the directives as part of layout.

Last edited 3 years ago by Ryan J Ollos (previous) (diff)

comment:2 Changed 4 years ago by Ryan J Ollos

I had been thinking about looking at making a theme that worked with ThemeEnginePlugin, but haven't investigated enough to form any opinion about what would work best, all things considered. Which way would you implement it?

comment:3 Changed 4 years ago by Ryan J Ollos

Status: newassigned

comment:4 Changed 4 years ago by Odd Simon Simonsen

I don't know TracHacksPlugin or ThemeEnginePlugin, and find that writing streamfilters is pain if I don't first have working template code to 'convert'. So site.html is by far the easiest to write and maintain for me.

However, I've looked over the earlier templates customizations, and I cannot find more things missing? All I've done is add support for the stylesheet + new ticket text, so any further customization must be part of some plugin code. And if you want it all in a plugin, it should be easy to convert these two trivial py:match directives to streamfilters.

comment:5 Changed 4 years ago by Ryan J Ollos

Summary: Port site templates from ClearSilver to GenshiPackage site templates after porting from ClearSilver to Genshi

comment:6 Changed 3 years ago by Ryan J Ollos

Images from server were captured in [13510], see comment:98:ticket:10193.

comment:7 Changed 3 years ago by Ryan J Ollos

site.html can be found in comment:98:ticket:10193.

comment:8 Changed 2 years ago by Michael Renzmann

In 14484:

3.0.0dev: Background image is added by style.css. Refs #11164.

comment:9 Changed 2 years ago by Ryan J Ollos

[14484-14485] was committed by me. I didn't realize before the commit that the SVN credentials for otaku42 are cached on the server.

Last edited 2 years ago by Ryan J Ollos (previous) (diff)

comment:10 Changed 2 years ago by Michael Renzmann

In 14485:

3.0.0dev: Images in htdocs/png are deployed. Refs #11164.

comment:11 Changed 2 years ago by Ryan J Ollos

Type: defectenhancement

comment:12 Changed 2 years ago by Ryan J Ollos

Status: assignedaccepted

comment:13 Changed 2 years ago by Ryan J Ollos

Description: modified (diff)

comment:14 in reply to:  4 Changed 2 years ago by Ryan J Ollos

Replying to osimons:

However, I've looked over the earlier templates customizations, and I cannot find more things missing? All I've done is add support for the stylesheet + new ticket text, so any further customization must be part of some plugin code. And if you want it all in a plugin, it should be easy to convert these two trivial py:match directives to streamfilters.

I think that all of the styling has been restored, but please let me know if you find anything else missing.

In absence of any additional findings, the last step for this ticket will be to move the template code in site.html to TracHacksPlugin.

comment:15 Changed 21 months ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

In 14751:

3.0.0dev: Add newticket notice in ITemplateStreamFilter. Fixes #11164.

comment:16 Changed 21 months ago by Ryan J Ollos

In 14752:

3.0.0dev: Remove print statement. Refs #11164.

comment:17 Changed 21 months ago by Ryan J Ollos

Changes have been deployed to https://bobcat.edgewall.com for testing.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.