Modify

Opened 3 years ago

Closed 18 months ago

Last modified 18 months ago

#11164 closed enhancement (fixed)

Package site templates after porting from ClearSilver to Genshi

Reported by: rjollos Owned by: rjollos
Priority: normal Component: TracHacksPlugin
Severity: normal Keywords: clearsilver genshi templates
Cc: hasienda, osimons Trac Release:

Description (last modified by rjollos)

As osimons mentioned in comment:45:ticket:10193, the site templates need to be ported from ClearSilver to Genshi. I'll suggest that it makes sense to have TracHacksPlugin install the templates so that they'll be maintained in source control, versioned and installed as part of the package.

Attachments (0)

Change History (17)

comment:1 Changed 3 years ago by osimons

Or redo changes as streamfilters. Or redo them as a theme that includes the directives as part of layout.

Last edited 2 years ago by rjollos (previous) (diff)

comment:2 Changed 3 years ago by rjollos

I had been thinking about looking at making a theme that worked with ThemeEnginePlugin, but haven't investigated enough to form any opinion about what would work best, all things considered. Which way would you implement it?

comment:3 Changed 3 years ago by rjollos

  • Status changed from new to assigned

comment:4 follow-up: Changed 3 years ago by osimons

I don't know TracHacksPlugin or ThemeEnginePlugin, and find that writing streamfilters is pain if I don't first have working template code to 'convert'. So site.html is by far the easiest to write and maintain for me.

However, I've looked over the earlier templates customizations, and I cannot find more things missing? All I've done is add support for the stylesheet + new ticket text, so any further customization must be part of some plugin code. And if you want it all in a plugin, it should be easy to convert these two trivial py:match directives to streamfilters.

comment:5 Changed 3 years ago by rjollos

  • Summary changed from Port site templates from ClearSilver to Genshi to Package site templates after porting from ClearSilver to Genshi

comment:6 Changed 3 years ago by rjollos

Images from server were captured in [13510], see comment:98:ticket:10193.

comment:7 Changed 2 years ago by rjollos

site.html can be found in comment:98:ticket:10193.

comment:8 Changed 21 months ago by otaku42

In 14484:

3.0.0dev: Background image is added by style.css. Refs #11164.

comment:9 Changed 21 months ago by rjollos

[14484-14485] was committed by me. I didn't realize before the commit that the SVN credentials for otaku42 are cached on the server.

Last edited 21 months ago by rjollos (previous) (diff)

comment:10 Changed 21 months ago by otaku42

In 14485:

3.0.0dev: Images in htdocs/png are deployed. Refs #11164.

comment:11 Changed 21 months ago by rjollos

  • Type changed from defect to enhancement

comment:12 Changed 21 months ago by rjollos

  • Status changed from assigned to accepted

comment:13 Changed 21 months ago by rjollos

  • Description modified (diff)

comment:14 in reply to: ↑ 4 Changed 21 months ago by rjollos

Replying to osimons:

However, I've looked over the earlier templates customizations, and I cannot find more things missing? All I've done is add support for the stylesheet + new ticket text, so any further customization must be part of some plugin code. And if you want it all in a plugin, it should be easy to convert these two trivial py:match directives to streamfilters.

I think that all of the styling has been restored, but please let me know if you find anything else missing.

In absence of any additional findings, the last step for this ticket will be to move the template code in site.html to TracHacksPlugin.

comment:15 Changed 18 months ago by rjollos

  • Resolution set to fixed
  • Status changed from accepted to closed

In 14751:

3.0.0dev: Add newticket notice in ITemplateStreamFilter. Fixes #11164.

comment:16 Changed 18 months ago by rjollos

In 14752:

3.0.0dev: Remove print statement. Refs #11164.

comment:17 Changed 18 months ago by rjollos

Changes have been deployed to https://bobcat.edgewall.com for testing.

Add Comment

Modify Ticket

Action
as closed The owner will remain rjollos.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.