[Patch] Milestones on versions page are not shown in 0.12/trunk & /versions not working

[AlexK]

When the patch I wrote was applied 2 years ago, the whole "show milestones underneath each version" feature was only applied to the 0.11 folder but not 0.12. Therefore this feature is no longer part of trunk!

[Ryan J Ollos]

Are you referring to [10468] / #7620?

[AlexK]

Fixes roadmap version view and regex bug

[AlexK]

Patch fixes milestones to be available in version view again, adapted for trac 1.0 CSS style. Also fixes an infinite recursion caused by incorrect regex in versions.py when trying to view /versions as it was incorrectly matched here (caused by previous commit that tried to fix new version page not matched).

[anonymous]

Oops, had a bug due to incorrect indention in the first version of the patch.

[AlexK]

Corrected version

[AlexK]

Previous patch plus removed ul/li marker in roadmap view

[Ryan J Ollos]

I probably won't get to this for a few days, but it's in my near-term work plan.

[Ryan J Ollos]

Replying to AlexK:

Also fixes an infinite recursion caused by incorrect regex in versions.py when trying to view /versions as it was incorrectly matched here (caused by previous commit that tried to fix new version page not matched).

I haven't successfully reproduced the infinite recursion issue, however I confirm that the regex doesn't work as intended. I setup some tests and modified the regex. The previous commit that caused the issue was [12231].

As for the rest of the changes, they'll take me a while to sort through. If you were to break up this up into a series of patches representing concise changes, that would speed up the process.

[Ryan J Ollos]

In 13341:

Added unit test harness and failing unit test for VisibleVersion.match_request. Refs #11179.

[Ryan J Ollos]

In 13342:

Fixed regression from [12231]. Refs #10354, #11179.

VisibleVersion.match_request should not return True for the path /versions.

[AlexK]

Adaptions for Trac 1.2 and re-integrated the progress bars on the version overview page

[Ryan J Ollos]

@AlexK: Would you consider rebasing your changes on the trunk again? There were some major changes in r16610 to adapt to the Trac 1.0 database API. If you revise the patch I'll commit it.