With Trac 1.0.3 or later user email validation often fails because of caching in the env.get_known_users() function

[sammcz]

After upgrading TRAC to 1.0.4 i got many reports about broken email validation. In SMTP server logs i found that TRAC is not attempting to send email in many cases. In the trac log i found many records like this:

Mar  8 03:46:35 sphere Trac[api] INFO: Email verification requested for user: BrigittMcewen
Mar  8 03:46:35 sphere Trac[notification] INFO: Email address w/o domain: BrigittMcewen
Mar  8 03:46:35 sphere Trac[notification] INFO: no recipient for a ticket notification
Mar  8 03:46:35 sphere Trac[session] INFO: Refreshing session BrigittMcewen

This is not happens on every registration, but in about 50% cases. Of course this user have valid email and not only username. Then i wrote a test script to repeat the issue and found that it is caused by ​recent changes in the trac caching. AccountManager edits attributes directly, so at some point cached records are not valid anymore. After adding few self.env.invalidate_known_users_cache() calls to the code issue was resolved.

[sammcz]

JFYI - i am using Trac 1.0.4 and TracAccountManager 0.4.4.

[sammcz]

quick and dirty fix for the problem

[sammcz]

I was able to find that bug is trigged only when notification is enabled, e.g. notify_actions = new,change,delete in the trac.ini. So probably during notification it updates users cache with a wrong data. My patch fixing issue, however i think it is not accurate or complete. I will try to provide better patch soon.

[sammcz]

This patch invalidates cache if there are any actions with users database

[samm@…]

Hi, any chance to get it committed before ongoing 0.5?

[Ryan J Ollos]

Yes, see #12569.

[Ryan J Ollos]

In 15717:

0.5dev: Clear known users cache in model functions

More changes are needed to cover all possible cases in
which the cache needs to be cleared.

Refs #12228.

[Ryan J Ollos]

#13000 closed as a duplicate, reporting no email sent when using reset password from the admin panel.

[Ryan J Ollos]

In 16869:

TracAccountManager 0.5dev: Clear known users cache

Minor revisions to r15717 and addition of test coverage.

Refs #12228.

[Ryan J Ollos]

Please test r16869 and let me know if it's not working for you. I think the issue is resolved.

[Ryan J Ollos]

In 16887:

TracAccountManager 0.5dev: Workaround ​trac:#12929

This revises r16869.

Refs #12228.

[Ryan J Ollos]

In 16888:

TracAccountManager 0.5dev: Revert unintended changes in r16887

Refs #12228.