Modify ↓

Opened 8 years ago

Closed 8 years ago

#12661 closed enhancement (fixed)

Support review of differences between revisions of files

Reported by: Cinc-th Owned by: Cinc-th
Priority: normal Component: PeerReviewPlugin
Severity: normal Keywords:
Cc: Ryan J Ollos Trac Release: 0.12

Description

The plugin allows reviewing a set of files at a specific revision. It would be useful to be able to review the difference to this revision at a later point in time.

  • Create a followup review with the files from the source review automatically added (similar to the resubmit feature).
  • Allow selection of a new revision

When performing the followup review:

  • Display a difference view of old and new revision
  • Let user see the comments of the old review
  • Allow adding comments to the new review

The view would be similar to the Trac changeset view.

Attachments (0)

Change History (6)

comment:1 Changed 8 years ago by Cinc-th

In 15204:

Support for followup reviews. Different file revisions may be reviewed side by side.

Refs #12661

comment:2 Changed 8 years ago by Cinc-th

Owner: changed from Olemis Lang to Cinc-th
Status: new → assigned

comment:3 Changed 8 years ago by Cinc-th

In 15222:

Old comments were hidden for modified lines when viewing differences inline.

Refs #12661

comment:4 Changed 8 years ago by Cinc-th

In 15229:

Show a message when files are identical when doing a folloup review.

Refs #12661

comment:5 Changed 8 years ago by Cinc-th

In 15247:

Code for message about identical files was completely broken. See [15229] for reference.

Refs #12661

comment:6 Changed 8 years ago by Cinc-th

Resolution: → fixed
Status: assigned → closed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Cinc-th.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.