Using deprecated database API

[anonymous]

Plugin use deprecated in TRAC 1.2 databаse API and don`t work on TRAC 1.2 installation. For example in auth.py

db = self.env.get_db_cnx()

[Ryan J Ollos]

In 16058:

2.0.2: Require Trac >= 1.0

Refs #12980.

[bebbo]

In 16068:

refs #12980

• added support for the new db interface

refs #12823

• added support for paged ldap queries using SimplePagedResultsControl

[bebbo]

please test the version 2.1.0-SNAPSHOT

[Ryan J Ollos]

If you are aiming for Trac < 1.0 compatibility, you'll want to modify r16058. I don't bother with Trac < 1.0 anymore. If you are aiming for only Trac >= 1.0 compatibility, you can drop the complexity of _get_db and just use self.env.db_query and self.env.db_transaction everywhere, as described in ​trac:TracDev/DatabaseApi#Trac1.0API.

The general guidance is to use self.env.db_query if the statements contain only SELECTs, otherwise use self.env.db_transaction.

[Ryan J Ollos]

Btw, thanks for picking up development of this plugin again! It definitely needs some care, and your contributions are valuable to the community. I don't have much experience with LDAP so I've never been able to help much with this plugin. Before it had a real maintainer I would try to fix things here and there, when the fix looked obvious. I hope to get up to speed on LDAP one of these days.

[bebbo]

Replying to rjollos:

If you are aiming for Trac < 1.0 compatibility, you'll want to modify r16058. I don't bother with Trac < 1.0 anymore. If you are aiming for only Trac >= 1.0 compatibility, you can drop the complexity of _get_db and just use self.env.db_query and self.env.db_transaction everywhere, as described in ​trac:TracDev/DatabaseApi#Trac1.0API.

The requirement >= 1.0 is ok for me. I wanted to minimize the code changes, so I went for this way.