Workflow graph generation for apache frontend.

[w1zdun@…]

Hi,

I wonder if it will be posible to incorporate incorporate attached patch. It allows to generate workflow diagram in directory hosted by apache.

Best, Michał

[Jun Omae]

You should use RewriteRule or Alias rather than the patch.

Also, default of diagram_path should not be /tmp. That is pretty insecure.

[Jun Omae]

Environment.get_htdocs_dir is available since Trac 1.0.11. The patch would break compatibility with Trac 1.0.10 or early.

[w1zdun@…]

Hi,

thanks for reply.

Patch will only be activated if in trac.ini you will configure it. For me it is:

[workflow-admin]
diagram_path_enable = true
diagram_path = /var/www/vhost_site/htdocs/site

I agree, that /tmp isn't the best choice. I should have leave it empty.

In my enviroment diagram image was created by trac user with with  0600 permisions. Thus change to 0664. I have apache runing on apache user and WSGI on trac user so apache process cannot get access to diagram file. Even Alias or RewriteRule won't help me with this.

I'm quite new to trac but in my environment get_htdocs_dir is pointing to trac project location and I'm not sure that I would like to expose this location to apache.

Diagram file will be regenerated as result of workflow changes so using trac-admin ... deploy ... seams impractical.

Thanks, Michał

[Jun Omae]

I think what you need is os.chmod(tmp, 0664) rather than diagram_path option.

[Jun Omae]

The image files are created with 0600 permission because using tempfile.mkstemp.

Could you please try the following patch? umask value would be respected after the changes.

workflowadmin/tracworkflowadmin/web_ui.py

@@ -5 +5 @@
 import inspect
 import os
 import re
+import shutil
 import time
 from cStringIO import StringIO
 from pkg_resources import resource_filename, parse_version
@@ -487 +488 @@
             finally:
                 proc.stdin.close()
                 proc.wait()
-        except:
-            os.remove(tmp)
-            raise
-        else:
             try:
                 os.remove(path)
             except:
                 pass
-            os.rename(tmp, path)
+            shutil.copyfile(tmp, path)
+        finally:
+            try:
+                os.remove(tmp)
+            except:
+                pass
 
     _default_workflow = (
         ('leave', 'new,assigned,accepted,reopened,closed -> *'),