Modify

Opened 7 years ago

Closed 6 months ago

#7426 closed enhancement (fixed)

Dynamicity of Trac (Show number of registered users)

Reported by: anonymous Owned by: Steffen Hoffmann
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords: admin panel
Cc: Trac Release: 0.11

Description

show the number of registered users on top of main page

Attachments (2)

ReportPage.png (9.3 KB) - added by Ryan J Ollos 4 years ago.
th7426-r12500-1.patch (1.2 KB) - added by Ryan J Ollos 4 years ago.
Patch against r12500 of the trunk.

Download all attachments as: .zip

Change History (22)

comment:1 Changed 7 years ago by Ryan J Ollos

Summary: Dynamicity of tracDynamicity of Trac (Show number of registered users)

comment:2 Changed 5 years ago by Ryan J Ollos

Component: Request-a-HackAccountManagerPlugin
Owner: changed from anybody to Steffen Hoffmann

I think we should provide the number of registered users in the AccountManagerPlugin via the UserStats macro.

comment:3 Changed 5 years ago by Steffen Hoffmann

Keywords: macro added

Yes, that fits in there indeed.

comment:4 in reply to:  3 Changed 5 years ago by Steffen Hoffmann

Priority: highestnormal

Replying to hasienda:

Yes, that fits in there indeed.

But the priority is not serious. This can easily be postponed behind the acct_mgr-0.4 release.

comment:5 Changed 4 years ago by Steffen Hoffmann

Hm, isn't it already there?

UserQuery(count)

will yield exactly the number of known users, see account-/user-related WikiMacros for everyone ("Requires USER_VIEW permission for output in any format other then 'count'."). Thoughts?

comment:6 Changed 4 years ago by Ryan J Ollos

Yeah, that works well for me. I think we are covered on the macro side.

It might be nice to show the number of registered users somewhere on the /admin/accounts/users page, but that is a separate matter.

comment:7 in reply to:  6 ; Changed 4 years ago by Steffen Hoffmann

Keywords: admin panel added; macro removed

Replying to rjollos:

Yeah, that works well for me. I think we are covered on the macro side.

Thanks for confirmation.

It might be nice to show the number of registered users somewhere on the /admin/accounts/users page, but that is a separate matter.

Oh, good catch , so why not read this request like that then ('main page' == 'user admin panel')? I'll do that.

comment:8 in reply to:  7 Changed 4 years ago by Ryan J Ollos

Replying to hasienda:

Oh, good catch , so why not read this request like that then ('main page' == 'user admin panel')? I'll do that.

Yeah, the request is a bit ambiguous, but that makes sense. I looked at the user admin panel for a while, but the best place to locate the user count didn't jump out at me. Perhaps to the right of Manage User Accounts, like is done on the report page.

Changed 4 years ago by Ryan J Ollos

Attachment: ReportPage.png added

comment:9 Changed 4 years ago by Steffen Hoffmann

(In [12496]) AccountManagerPlugin: Add number of accounts into user admin panel, refs #7426.

Changed 4 years ago by Ryan J Ollos

Attachment: th7426-r12500-1.patch added

Patch against r12500 of the trunk.

comment:10 Changed 4 years ago by Ryan J Ollos

From my work on t:#10743, I know of a different way to accomplish this, which could avoid adding the additional stylesheet: th7426-r12500-1.patch.

comment:11 Changed 4 years ago by Ryan J Ollos

On second look, after the patch is applied the styling of the text is slightly different. I think the patch is an improvement though since the text is slightly larger, so I still favor applying the patch.

comment:12 Changed 4 years ago by Steffen Hoffmann

(In [12514]) AccountManagerPlugin: Obsolete additional CSS styles, refs #7426.

Changing to another .class allows to remove report.css, that has been added in [12496]. Thanks to Ryan J Ollos for proposing this simplification.

comment:13 Changed 4 years ago by Ryan J Ollos

It appears I may have led you astray here because the trac-count class wasn't added until [t 11127], meaning the class isn't available in Trac < 1.0. I think the styling is nice though, and use of the trac-count class will provide consistent styling in Trac >= 1.0. Maybe we should copy the class to acct_mgr.css temporarily, until support for Trac < 1.0 is dropped (AccountManager 0.5 and later?).

comment:14 in reply to:  13 ; Changed 4 years ago by Steffen Hoffmann

Replying to rjollos:

It appears ... the class isn't available in Trac < 1.0. ... Maybe we should copy the class to acct_mgr.css temporarily, until support for Trac < 1.0 is dropped (AccountManager 0.5 and later?).

Good point. Let's do that.

Enough new stuff has been prepared for another "main" dot-release, so acct_mgr-0.5 will certainly get released before switching the plugin db backend code to Trac 1.0 API, consequently before 0.6dev.

comment:15 Changed 4 years ago by Steffen Hoffmann

(In [12532]) AccountManagerPlugin: Supply copy of recent Trac CSS style inside the plugin, refs #7426.

Done for compatibility with Trac < 1.0, even if its a very minor tweak.

comment:16 in reply to:  14 Changed 4 years ago by Ryan J Ollos

Replying to hasienda:

Enough new stuff has been prepared for another "main" dot-release, so acct_mgr-0.5 will certainly get released before switching the plugin db backend code to Trac 1.0 API, consequently before 0.6dev.

Ah, right. I have the development plan straight in my mind, but keep mixing up the numbers when it comes time to type ;)

comment:17 Changed 4 years ago by Ryan J Ollos

Oh, and just to avoid confusion down the road, we have everything straight in this ticket, but the code comment says Trac <= 1.0, whereas it should say Trac < 1.0.

comment:18 Changed 4 years ago by Ryan J Ollos

See also t:#11027, which this ticket inspired.

comment:19 Changed 4 years ago by Steffen Hoffmann

(In [12571]) AccountManagerPlugin: Add descriptive tool-tip to 'Toggle account approval', refs #7426 and #8595.

A CSS style comment is now corrected as well.

Thanks to Ryan J Ollos for hints on these minor issues, nevertheless I care and I'm happy to receive code reviews for getting things straight.

comment:20 Changed 6 months ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Steffen Hoffmann.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.