TracLink to a PDF in the repository is not redirected

[boleslaw.tokarski@…]

Hello,

I gave the plugin a try. It looks good when the file referenced is an attachment. However when you use [source:file.pdf] then the preview is still generated. I tried that on a git repository, but I suppose that svn behaves the same way. It would be cool to have that straight. Thanks for your good work!

Cheers!

[zgoey@…]

Yes, svn behaves in the same way. I agree that this would be a nice enhancement.

[Ryan J Ollos]

Proposed patch, which is nearly a complete rewrite of this tiny plugin.

trunk/pdfredirector/pdfredirector.py

@@ -13 +13 @@
         return template, data, content_type
 
     def pre_process_request(self, req, handler):
+        
         path = req.path_info.strip('/').split('/')
-        if len(path) < 2 or path[0] != 'attachment' or req.args.get('action') == 'delete':
-            return handler
-
-        if not path[-1].lower().endswith('.pdf'):
-            return handler
-
-        filename = req.href(*(['raw-attachment'] + path[1:]))
-
-        req.redirect(filename) 
+                
+        if len(path) > 1 and path[-1].lower().endswith('.pdf'):
+            if path[0] == 'attachment' and not req.args.get('action') == 'delete':
+                filepath = req.href(*(['raw-attachment'] + path[1:]))
+                req.redirect(filepath)
+            elif path[0] == 'browser':
+                path[0] = 'export'
+                rev = req.args.get('rev', 'HEAD')
+                path.insert(1, rev)
+                filepath = req.href('/'.join(path))
+                req.redirect(filepath)
 
-
-
-
-
+        return handler

[Ryan J Ollos]

(In [11799]) Refs #8066: Redirect TracLink to a PDF in the repository.

[Ryan J Ollos]

Code review and feedback welcomed and appreciated.

[Ryan J Ollos]

I think it is time to bump the revision and create a tag for this. Anyone r11799 or later that can give some feedback?

[Ryan J Ollos]

(In [12181]) Refs #8066: Bumped version to 0.3. Added tags directory.

[Ryan J Ollos]

(In [12182]) Fixes #8066: Tagged version 0.3.