When setting blocking/blocked, opposing field it is not set in corresponding ticket

[Hugh]

If I set #1 to be blocked by #2, the Blocking field on #2 is not updated. A comment is added to #2 that says "Blocking 1 added", but the actual Blocking field itself is not updated. Any reason why this would not be happening properly?

• Using v3.0 on Trac 0.12

[Hugh]

I'm not sure if I need to supply any more information, but let me know if there's any crucial data I haven't given.

[anonymous]

Same problem here with the same version of trac and plugin....

[Ryan J Ollos]

Issue seems to be resolved with the latest version of the plugin (3.0.2). Please reopen if you can reproduce the issue with that version, or a later version.

[anonymous]

Happens again.

• TracMasterTickets 3.0.5dev-r13319
• Trac 1.0.1

I also have same problem with ticketref plugin.

[Marcin Wisnicki <mwisnicki@…>]

It doesn't happen every time. In fact I can't reproduce it now.

[anonymous]

Same here:

• TracMasterTickets 3.0.5dev-r13319
• Trac 1.0.1

[anonymous]

I came across the same issue with Trac 1.0.1 and TracMasterTickets 3.0.5. I tracked down the issue finding the following section of code to be at fault. By moving the lines of code the result for the sql update statement is properly checked and the new value is inserted if no rows were updated. The bug only occurs when a custom field has not been created in the database for the ticket that you are adding to a blocked or blocked by field in the ticket you are editing.

model.py

@@ -106 +106 @@
                     cursor.execute('UPDATE ticket_custom SET value=%s WHERE ticket=%s AND name=%s',
                                    (new_value, n, field))
 
-                    # refresh the changetime to prevent concurrent edits
-                    cursor.execute('UPDATE ticket SET changetime=%s WHERE id=%s', (when_ts, n))
-
                     if not cursor.rowcount:
                         cursor.execute('INSERT INTO ticket_custom (ticket, name, value) VALUES (%s, %s, %s)',
                                        (n, field, new_value))
 
+                    # refresh the changetime to prevent concurrent edits
+                    cursor.execute('UPDATE ticket SET changetime=%s WHERE id=%s', (when_ts, n))
+
+
         # cursor.execute('DELETE FROM mastertickets WHERE source=%s OR dest=%s', (self.tkt.id, self.tkt.id))
         # data = []
         # for tkt in self.blocking:

[Ryan J Ollos]

In 14323:

Untested patch for failure to update field in linked ticket. Fixes #9072.