dynamically adding textareas causes multiple toolbars for existing textareas

[wasserman]

I have a use case where new textarea form fields can be added dynamically via JavaScript. The current logic adds new TracWysiwyg instances with corresponding toolbars to all textareas via TracWysiwyg.initialize​. When a new textarea is created this causes each existing textarea to get an additional toolbar. This can be avoided by creating a property in each textarea and associating it to its TracWysiwyg instance after it is created. Here is suggested patch:

tracwysiwyg/htdocs/wysiwyg.js

@@ -4005 +4005 @@
     var textareas = document.getElementsByTagName("textarea");
     for (var i = 0; i < textareas.length; i++) {
         var textarea = textareas[i];
-        if (/\bwikitext\b/.test(textarea.className || "")) {
-            TracWysiwyg.newInstance(textarea, options);
+        if (/\bwikitext\b/.test(textarea.className || "")
+            && !textarea.wysiwyg) {
+            textarea.wysiwyg = TracWysiwyg.newInstance(textarea, options);
         }
     }
 };

[Jun Omae]

In 13453:

TracWysiwygPlugin: marks initialized on data-tracwysiwyg-initialized attribute of textarea to prevent double-initializing (fixed #9596)