Changes between Version 2 and Version 3 of CodeReviewPlugin/Concepts

Timestamp:

Nov 4, 2015, 10:58:49 AM (8 years ago)

Author:

figaro

Comment:

Cosmetic changes, tagged as proposal

CodeReviewPlugin/Concepts

@@ -1 @@
-= CodeReviewPlugin Concepts =
+= CodeReviewPlugin Concepts
 
-== Basic idea ==
+== Basic idea
+
  * Whenever a changeset is displayed, review information is available:
   * Reviewer
@@ -12 +13 @@
   * To make this easier, besides the changeset revision, the changeset author is also redundantly store in this table.
 
-== Ideas ==
-( If approved, turn them to tickets and mark them here accordingly. )
+== Ideas
+
+If approved, turn them to tickets and mark them here accordingly.
 
  * Send an email to the author, whenever a changeset is REJECTED.
@@ -41 +43 @@
 with that:
 My original idea was to save the reviews to the subversion changeset via properties with some simple formatting, and:
- * Also suggest a link to code review, if present, when a list if files is presented for large changesets (right next to "view diffs")
- * Modify the Annotation view template to parse the special properties, and pull out reviews specific to the current file/selected revision and
+ * Also suggest a link to code review, if present, when a list if files is presented for large changesets, right next to "view diffs".
+ * Modify the Annotation view template to parse the special properties, and pull out reviews specific to the current file/selected revision and:
   * Show each review by author (allow multiple reviewers)
   * only show the review outcome (accepted, rejected, ...make this configurable?) as a link to the full review text as a wiki page/section of a page (maybe 1 page per changeset, 1 heading section per file?)
    * This allows a code review summary to just be a print of a wiki page, or, a print of all the sub page via, say, Wiki-Print
  * changeset string format could be something as simple as CR:REVNUM:File:Author:result as the property name, then the comments.
-   * then on the annotation hover, parsed into: (in pseudo code, sorry, not sure how else to convey the idea)
+   * then on the annotation hover, parsed into: (in pseudo code)
 {{{
 for all properties on changeset REVNUM:
@@ -61 +63 @@
 
 Now I realize this is tied to subversion, but could some of these ideas be incorporated into this DB based implementation.
-Also, I apologize for the verboseness of this, not sure what the best way to convey these concepts in compact form.