Changes between Version 1 and Version 2 of PeerReviewPlugin/Workflows

Timestamp:

May 9, 2016, 6:28:32 AM (8 years ago)

Author:

Cinc-th

Comment:

Added actual workflows

PeerReviewPlugin/Workflows

@@ -1 +1 @@
 = Workflows
 PeerreviewPlugin supports workflows for reviews. There is one for the author of a review and another one for reviewers. An administrator may change the workflow in ''trac.ini'' similar to [TracWorkflow ticket workflows].
-
-Reviewers may mark their individual progess just to inform the review author. The workflow states are not used for any other purpose or to impose any restrictions. For example it is possible for a review author to close a review even when none of the reviewers ever changed his personal workflow state.
-
-The overall review workflow controlled by the owner of the review (or a manager) is more involved. When setting a review to a finishing state all associated files are set to the same state. This means if the owner sets the review to ''approved'' all files are also set to ''approved''.
 
 == Review Workflow
@@ -11 +7 @@
 {{{#!ini
 [peerreview-resource_workflow]
-...
+approve = reviewed -> approved
+approve.name = Approve the review
+change_owner = * -> *
+change_owner.default = -1
+change_owner.name = Change Owner to
+change_owner.operations = set_review_owner
+change_owner.permissions = CODE_REVIEW_MGR
+close = new, reviewed, in-review -> closed
+close.name = Close review
+disapprove = reviewed -> disapproved
+disapprove.name = Deny this review
+reopen = closed, reviewed, approved, disapproved -> new
+reopen.permissions = CODE_REVIEW_MGR
+review-done = in-review -> reviewed
+review-done.name = Mark as reviewed
+reviewing = new -> in-review
+reviewing.default = 5
+reviewing.name = Start review
 }}}
+
+{{{
+#!Workflow width=600 height=400
+approve = reviewed -> approved
+approve.name = Approve the review
+change_owner = * -> *
+change_owner.default = -1
+change_owner.name = Change Owner to
+change_owner.operations = set_review_owner
+change_owner.permissions = CODE_REVIEW_MGR
+close = new, reviewed, in-review -> closed
+close.name = Close review
+disapprove = reviewed -> disapproved
+disapprove.name = Deny this review
+reopen = closed, reviewed, approved, disapproved -> new
+reopen.permissions = CODE_REVIEW_MGR
+review-done = in-review -> reviewed
+review-done.name = Mark as reviewed
+reviewing = new -> in-review
+reviewing.default = 5
+reviewing.name = Start review
+}}}
+When setting a review to a finishing state all associated files are set to the same state. This means if the owner sets the review to ''approved'' all files are also set to ''approved''.
 === Workflow operation ''set_review_owner''
 You may configure a custom workflow operation {{{set_review_owner}}} for reviews.
@@ -25 +61 @@
 
 == Reviewer Workflow
-To be written...
+Reviewers may mark their individual progess just to inform the review author. The workflow states are not used for any other purpose or to impose any restrictions. For example it is possible for a review author to close a review even when none of the reviewers ever changed his personal workflow state.
+{{{
+[peerreviewer-resource_workflow]
+reopen = in-review, reviewed -> new
+reopen.name = Reset review state to 'new'
+review_done = in-review -> reviewed
+review_done.name = Mark review as done.
+reviewing = new -> in-review
+reviewing.name = Start review
+}}}
+
+{{{
+#!Workflow width=500 height=300
+reopen = in-review, reviewed -> new
+reopen.name = Reset review state to 'new'
+review_done = in-review -> reviewed
+review_done.name = Mark review as done.
+reviewing = new -> in-review
+reviewing.name = Start review
+}}}