Ticket #173 (assigned task)

Opened 3 years ago

Last modified 2 years ago

Integrate login-related plugins

Reported by: coderanger Assigned to: mgood (accepted)
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords:
Cc: brad, coderanger, gunnar, dottedmag@dottedmag.net Trac Release: 0.8

Description

We clearly have too many implementations of alternate login mechanisms:

Given that Matt has made an extension point for this kind of thing, I propose that we merge both AuthForm? and DbAuth? into AccountManager.

Attachments

Change History

02/03/06 11:21:48 changed by brad

Whoops, didn't see this ticket before I added #174, #175, #176. I'm all for the merge.

02/03/06 13:07:24 changed by mgood

Yeah, I was going to bring that up when I saw DbAuthPlugin mentioned on the mailing list. Patches are welcome. The HTTP authentication used by AuthFormPlugin should be possible for validating users, though it won't be possible to implement the methods for listing/editing users.

02/19/06 16:25:42 changed by adeason@tjhsst.edu

I don't think AuthFormPlugin needs to be integrated with Db/AccountManager. The idea behind it is that you can use any kind of HTTP authentication method to use with it, and doesn't need to be managed by Trac. You could use any Apache module to auth off of Kerberos or LDAP or MySQL or whatever (or write some CGI to write your own). You could have a Trac module to manage accounts in a database and use that for HTTP auth with AuthForm?, but they are still definitely separate things.

03/15/06 09:54:56 changed by mgood

  • status changed from new to assigned.

adeason@tjhsst.edu: the point is that the AccountManagerPlugin also supports form-based authentication, so it's kind of redundant. As I said, the HTTP authentication could be added to AccountManager, so it's not necessary to keep it as a separate plugin.

06/15/06 16:09:35 changed by gunnar

  • cc changed from brad, coderanger to brad, coderanger, gunnar.
  • release set to 0.8.

11/10/06 22:30:35 changed by mgood

(In [1534]) * add an HttpAuthStore to support logins by checking the password against

HTTP authentication for a URL (re #173)

  • update the modules to check whether the current password store supports writing passwords or deleting accounts

(follow-up: ↓ 9 ) 12/22/06 09:18:54 changed by Mikhail Gusarov <dottedmag@dottedmag.net>

OpenidPlugin is another authentication plugin which can be integrated.

12/22/06 09:19:21 changed by anonymous

  • cc changed from brad, coderanger, gunnar to brad, coderanger, gunnar, dottedmag@dottedmag.net.

(in reply to: ↑ 7 ) 12/29/06 14:39:38 changed by anonymous

Replying to Mikhail Gusarov <dottedmag@dottedmag.net>:

OpenidPlugin is another authentication plugin which can be integrated.

Openid is pretty cool and I'm considering using it for one of my sites, but I don't think the OpenidPlugin will benefit from being part of the AccountManagerPlugin. The OpenidPlugin doesn't fit into any of the interfaces provided by the AccountManagerPlugin since it's very different from the username/password backends supported by the AccountManager. I don't really see any place they overlap, so I think it's best if they remain separate.

12/29/06 15:04:00 changed by mgood

Oops, that "anonymous" was me.

(follow-up: ↓ 12 ) 12/29/06 23:56:50 changed by Mikhail Gusarov <dottedmag@dottedmag.net>

Then OpenIdPlugin? and AccountManager plugin will be incompatible forever. I think it's possible to refactor AccountManagerPlugin a bit to separate account from the credentials, and then associate account with multiple types of credentials (password, SSL cert, OpenId? identity etc).

(in reply to: ↑ 11 ) 12/30/06 15:28:41 changed by mgood

Replying to Mikhail Gusarov <dottedmag@dottedmag.net>:

I think it's possible to refactor AccountManagerPlugin a bit to separate account from the credentials, and then associate account with multiple types of credentials (password, SSL cert, OpenId? identity etc).

That's beyond the scope of this ticket. This ticket is just meant to address the overlap between the several plugins that all implemented basically the same username/password style login forms. If you have some needs for integrating the Openid and AccountManager plugins please open a new ticket for that.


Add/Change #173 (Integrate login-related plugins)




Change Properties
Action