Changes between Initial Version and Version 1 of Ticket #12580, comment 2


Ignore:
Timestamp:
Nov 19, 2015, 12:29:19 AM (8 years ago)
Author:
Ryan J Ollos
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #12580, comment 2

    initial v1  
    1 It looks like Babel is required for this plugin: [browser:mailplugin/trunk/xmail/XMailEMailModule.py@:61#L52]. It would be a good idea to include `install_requires = ['Babel']` in `setup.py`, or else make Babel optional.
     1It looks like Babel is required for this plugin: [browser:mailplugin/trunk/xmail/XMailEMailModule.py@14670:61#L52]. It would be a good idea to include `install_requires = ['Babel']` in `setup.py`, or else make Babel optional.
    22
    33Side note: there is a transitive import `from trac.prefs.web_ui import Locale`. Instead, you should use `from trac.util.translation import Locale`: [trac:browser:tags/trac-1.0.9/trac/prefs/web_ui.py@:25#L17]. There are no guarantees that `trac.prefs.web_ui` will continue to import `Locale` in the future.