Changes between Initial Version and Version 2 of Ticket #12612


Ignore:
Timestamp:
Dec 14, 2015, 2:55:43 PM (8 years ago)
Author:
Ryan J Ollos
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #12612

    • Property Owner changed from Rob Guttman to Ryan J Ollos
    • Property Status changed from new to accepted

  • Ticket #12612 – Description

    initial v2  
    1 The plugin throws causing document ready functions to be not executed.
    2 At least with AgiloForTracPlugin this results to main navigation bar being missing.
     1The plugin throws causing document ready functions to be not executed. At least with AgiloForTracPlugin this results to main navigation bar being missing.
    32
    4 The problem is at https://trac-hacks.org/browser/dynamicfieldsplugin/trunk/dynfields/htdocs/rules.js#L175
    5 input.attr is undefined and hence results into error; also seen in the browser console.
     3The problem is at [browser:dynamicfieldsplugin/trunk/dynfields/htdocs/rules.js@15114:175#L175]. `input.attr` is undefined and hence results into error; also seen in the browser console.
    64
    75Original code:
    8 {{{
     6{{{#!javascript
    97  if (input.attr('id').slice(6) !== spec.trigger)
    108    return;
    … …  
    1210
    1311Patched:
    14 {{{
     12{{{#!javascript
    1513  if (input.attr('id') === undefined || input.attr('id').slice(6) !== spec.trigger)
    1614    return;
    17 
    1815}}}
    1916