Changes between Version 1 and Version 2 of Ticket #13074, comment 8
- Timestamp:
- Mar 11, 2017, 9:05:35 AM (7 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #13074, comment 8
v1 v2 12 12 Apparently #8796 did find a way to opt-out in the old `NotifyEmail` system. 13 13 14 Looks like !AccountManagerPlugin [source:accountmanagerplugin/trunk/acct_mgr/notification.py@15454 currently] relies on the deprecated `NotifyEmail` compatibility shims, where this workaround doesn't work. So this entire subsystem should be rewritten using the Trac 1.2 API. Then I guess a custom subscriber could provide a default subscription with priority `0` and adverb `never` for account notifications. (But `AlwaysEmailSubscriber` also has priority `0`!) Or possibly the account notifications should be sent by calling directly e.g. `NotificationSystem.distribute_event()` instead of `NotificationSystem.notify()`.14 Looks like !AccountManagerPlugin [source:accountmanagerplugin/trunk/acct_mgr/notification.py@15454 currently] relies on the !deprecated `NotifyEmail` compatibility shims, where this workaround doesn't work. So this entire subsystem should be rewritten using the Trac 1.2 API. Then I guess a custom subscriber could provide a default subscription with priority `0` and adverb `never` for account notifications. (But `AlwaysEmailSubscriber` also has priority `0`!) Or possibly the account notifications should be sent by calling directly e.g. `NotificationSystem.distribute_event()` instead of `NotificationSystem.notify()`. 15 15 16 16 I would in any case recommend not using `smtp_always_cc` if you don't want ''all emails'' to be CC'd there.