Changes between Version 23 and Version 24 of CodeReviewerPlugin
- Timestamp:
- Aug 8, 2015, 2:00:56 PM (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
CodeReviewerPlugin
v23 v24 19 19 When a review summary is provided, it gets added as a comment to all tickets referenced in the changeset (also shown above). 20 20 21 This plugin is inspired by [http ://code.google.com/p/gerrit/ Gerrit], which itself is Apache licensed. This tool would have to be reworked substantially to neatly integrate it into existing Trac tools and ticket workflow. The few existing Trac-based code review plugins (below) appear to be unmaintained. And so this plugin was born.21 This plugin is inspired by [https://www.gerritcodereview.com/ Gerrit], which itself is Apache licensed. This tool would have to be reworked substantially to neatly integrate it into existing Trac tools and ticket workflow. The few existing Trac-based code review plugins (below) appear to be unmaintained. And so this plugin was born. 22 22 23 23 See also: CodeReviewPlugin, PeerReviewPlugin, ExoWebCodeReviewPlugin … … 97 97 === Continuous Integration (Jenkins / Hudson / Bitten / etc.) 98 98 99 [http ://code.google.com/p/gerrit/ Gerrit's] philosophy is to treat a code review similar to a Jenkins test job, ie code changes do not get promoted to the next stage in a continuous integration / deployment pipeline until they pass a review. You can achieve this effect with this plugin via an included [browser:codereviewerplugin/0.12/coderev/util/reviewer.py Reviewer] class.99 [https://www.gerritcodereview.com/ Gerrit's] philosophy is to treat a code review similar to a Jenkins test job, ie code changes do not get promoted to the next stage in a continuous integration / deployment pipeline until they pass a review. You can achieve this effect with this plugin via an included [browser:codereviewerplugin/0.12/coderev/util/reviewer.py Reviewer] class. 100 100 101 101 In brief, [browser:codereviewerplugin/0.12/coderev/util/reviewer.py Reviewer] accepts a target git reference, eg "develop" or "master", and its {{{get_next_changeset()}}} method will return the changeset that is closest to that target (since the last changeset found) whose referenced ticket(s) have been completed. A "completed" ticket is one that passed the workflow tests described above: