Support Trac 1.0.x

[Chris Nelson]

Numerous minor issues.

[Chris Nelson]

Of note: once I got this working in 1.0.1, the fields I have unchecked for a ticket type are hidden on initial view of a ticket but reappear when the ticket preview kicks in. It seems there is a new hook that the processor needs to be tied to.

[Ryan J Ollos]

Replying to ChrisNelson:

Of note: once I got this working in 1.0.1, the fields I have unchecked for a ticket type are hidden on initial view of a ticket but reappear when the ticket preview kicks in. It seems there is a new hook that the processor needs to be tied to.

I encountered the same issue this week while working on CondFieldsPlugin, #11920. I didn't see an existing hook, but need to look closer. The only partially-relevant ticket I found on t.e.o is ​trac:#10852 (requesting a hook for a different event).

[Chris Nelson]

Replying to rjollos:

Replying to ChrisNelson:

Of note: once I got this working in 1.0.1, the fields I have unchecked for a ticket type are hidden on initial view of a ticket but reappear when the ticket preview kicks in. It seems there is a new hook that the processor needs to be tied to.

I encountered the same issue this week while working on CondFieldsPlugin, #11920. I didn't see an existing hook, but need to look closer. The only partially-relevant ticket I found on t.e.o is ​trac:#10852 (requesting a hook for a different event).

I wonder, though, if it isn't a bug rather than a missing feature. If I make an AJAX request to unhide and populate the preview area, why should the ticket header change? Is a display attribute being too-broadly applied?

[Chris Nelson]

The fields are revealed by

// Update ticket box
$("#ticket").replaceWith(items.filter('#ticket'));

in trac/ticket/templates/ticket.html. That function replaces the existing ticket header with entirely new elements, it does not just update the values. items has not been filtered by any extension point. The effect is that display: none added by TicketExt is lost and all elements are displayed.

I'm a jQuery newbie but I'm exploring this on ​StackOverflow.

Ultimately, this will require a change to Trac to either copy values only (leaving attributes in place) or allow request filters to process XHR requests for auto-preview. I lean toward the former as it is a narrow, local change that doesn't require new extension point behavior, etc.

[Chris Nelson]

I have a patch to Trac that lets the plugin do its job:

trac/ticket/templates/ticket.html

@@ -67 +67 @@
         $("#comment").focus(function() { comment_focused = true; })
                      .blur(function() { comment_focused = false; });
         $("#propertyform").autoSubmit({preview: '1'}, function(data, reply) {
+          function copyHeaderData(f, t) {
+            if (f.length != t.length) {
+              console.log('Shape mismatch');
+            }
+            else {
+              var i;
+              for (i = 0; i < t.length; ++i) {
+                t[i].innerHTML = f[i].innerHTML;
+              }
+            }
+          }
           var items = $(reply);
           // Update ticket box
-          $("#ticket").replaceWith(items.filter('#ticket'));
+          copyHeaderData(items.filter("#ticket").find("td"), $("#ticket td"));
           // Unthread, unrevert and update changelog
           if (!$('#trac-comments-oldest').checked())
             $('#trac-comments-oldest').click().change();

[Ryan J Ollos]

You'll also have to update the description, summary, status, resolution, timestamps in div.date, add the ticketdraft class to #ticket and possibly more. A jQuery version of your code that also updates the description and adds the "draft" background is:

trac/ticket/templates/ticket.html

@@ -79 +79 @@
         $("#propertyform").autoSubmit({preview: '1'}, function(data, reply) {
           var items = $(reply);
           // Update ticket box
-          $("#ticket").replaceWith(items.filter('#ticket'));
+          var newProps = $('table.properties td', items);
+          $('#ticket table.properties td').each(function(i) {
+            $(this).html(newProps.eq(i).html());
+          });
+          var newDescription = $('div.description div.searchable', items);
+          $('#ticket div.description div.searchable').html(newDescription.html(
+          if (items.hasClass('ticketdraft'))
+            $('#ticket').addClass('ticketdraft');
           // Unthread, unrevert and update changelog
           if (!$('#trac-comments-oldest').checked())
             $('#trac-comments-oldest').click().change();

When I got to this far I realized this was going to be very brittle code, and we probably need to make the autopreview behave the same as an explicit preview. We should probably open a ticket in Trac and get some dev input.

[Chris Nelson]

Replying to rjollos:

You'll also have to update the description, summary, status, resolution, timestamps in div.date,

I see what you mean about description, summary, status, and resolution.

I don't see any changes in the timestamps. Would that happen if someone changed the ticket under me?

add the ticketdraft class to #ticket

I don't see that that has any effect. <shrug>

and possibly more. A jQuery version of your code that also updates the description and adds the "draft" background is:

The "draft" background is present in my test bed.<shrug>

trac/ticket/templates/ticket.html

@@ -79 +79 @@
         $("#propertyform").autoSubmit({preview: '1'}, function(data, reply) {
           var items = $(reply);
           // Update ticket box
-          $("#ticket").replaceWith(items.filter('#ticket'));
+          var newProps = $('table.properties td', items);
+          $('#ticket table.properties td').each(function(i) {
+            $(this).html(newProps.eq(i).html());
+          });
+          var newDescription = $('div.description div.searchable', items);
+          $('#ticket div.description div.searchable').html(newDescription.html(
+          if (items.hasClass('ticketdraft'))
+            $('#ticket').addClass('ticketdraft');
           // Unthread, unrevert and update changelog
           if (!$('#trac-comments-oldest').checked())
             $('#trac-comments-oldest').click().change();

Thanks for the jQueryification. :-)

When I got to this far I realized this was going to be very brittle code, and we probably need to make the autopreview behave the same as an explicit preview. We should probably open a ticket in Trac and get some dev input.

I'll do that.

[Chris Nelson]

Opened ​trac:#11719.

[Ryan J Ollos]

Replying to ChrisNelson:

I don't see any changes in the timestamps. Would that happen if someone changed the ticket under me?

I didn't think of that possibility. The timestamps would definitely need to be updated though if the display is relative rather than absolute.

add the ticketdraft class to #ticket

I don't see that that has any effect. <shrug>

and possibly more. A jQuery version of your code that also updates the description and adds the "draft" background is:

The "draft" background is present in my test bed.<shrug>

Maybe your patch somehow accounts for that. When I briefly tried it I was getting the Shape mismatch in the console and didn't look any deeper.

[Chris Nelson]

I tried without success to iterate the elements and copy display from the existing page to the new items.