`Graphviz.render()` does not work with the default value for `filename`

[ebouaziz@…]

Traceback (most recent call last):
  File "/somepath/trac/trac/mimeview/api.py", line 795, in render
    rendered_content, filename, url)
  File "/somepath/trac-plugins/graphviz-plugin/graphviz/graphviz.py", line 200, in render
    ext = filename.split('.')[1]
AttributeError: 'NoneType' object has no attribute 'split'

The default value for filename is None: graphvizplugin/trunk/graphviz/graphviz.py#L199​

Trac version is 1.1.3

[anonymous]

Still a problem with Trac 1.3.3dev, graphviz plugin 1.3.0.1dev

[Jun Omae]

Could you try the following patch?

graphvizplugin/trunk/graphviz/graphviz.py

@@ -198 +198 @@
         return 0
 
     def render(self, context, mimetype, content, filename=None, url=None):
-        ext = filename.split('.')[1]
-        name = 'graphviz' if ext == 'graphviz' else 'graphviz.%s' % ext
+        ext = filename.split('.')[1] if filename else None
+        name = 'graphviz' if not ext or ext == 'graphviz' \
+               else 'graphviz.%s' % ext
         text = content.read() if hasattr(content, 'read') else content
         return self.expand_macro(context, name, text)
 

[anonymous]

Seems to work. (But I don't know the exact scenario where filename is None. I just found the error in the logfile without much context.)

[Ryan J Ollos]

In 17295:

1.0.0.8dev: Avoid AttributeError

Patch by Jun Omae.

Refs #12825.

[Ryan J Ollos]

In 17296:

1.0.0.9dev: Avoid AttributeError

Merge of r17295 from 1.0 branch.

Refs #12825.

[Ryan J Ollos]

In 17297:

1.3.0.1dev: Avoid AttributeError

Merge of r17296 from 1.2 branch.

Fixes #12825.