Upgrade jquery-textcomplete

[Peter Suter]

This still uses jquery-textcomplete v0.3.3.

Upgrading to a newer version improves e.g. handling of ESC-key. (E.g. dismissed menu remains dismissed when moving cursor position.)

[Peter Suter]

[15953]

[Jun Omae]

After [15953], dropdown is shown in front of typing text. I'm using Firefox 49.

This issue occurs with v1.1.0 but doesn't occur with v1.0.0. Workaround is to add body { margin: 0 !important }.

[Peter Suter]

Thanks for noticing.

Also TAB-key does not reopen dropdown anymore. ​Upstream issue filed.

[Peter Suter]

I'm not good with CSS, but it seems we can drop:

wikiautocomplete/htdocs/css/jquery.textcomplete.css

@@ -28 +28 @@
 .dropdown-menu {
     list-style: none;
     padding: 0;
-    margin: 0;
 }
 
 .dropdown-menu a:hover {

Edit: Disregard this. That's just luck(?)

[Peter Suter]

It seems fixed in Trac 1.2 with jQuery upgraded from 1.8.3 to 1.11.3. (Something about $('body').offsetParent() changed and returns the html or body element.)

[Jun Omae]

This issue occurs only with Firefox. Also, it occurs with jQuery 1.8.3 but doesn't with 1.9.0.

Workaround is to add margin-top of body element to .dropdown-menu class.

wikiautocomplete/htdocs/js/wikiautocomplete.js

@@ -154 +154 @@
         appendTo: $('body'),
         maxCount: 10000
     });
+
+    if (/^1\.[78]\./.test($.fn.jquery) && $.browser.mozilla &&
+        navigator.userAgent.indexOf('like Gecko') === -1 /* IE 11 */)
+    {
+        var margin = $('body').css('margin-top');
+        if (margin && margin !== '0px') {
+            if (!/px$/.test(margin))
+                margin += 'px';
+            $('<style type="text/css">.dropdown-menu { margin-top: ' +
+              margin + ' !important }</style>').appendTo('head');
+        }
+    }
 });

[figaro]

In general, with this workaround and the activity on this plugin, should it still be tagged as alpha?

[Peter Suter]

The workaround looks OK.

I removed the alpha tag.

[Jun Omae]

In 15959:

WikiAutoCompletePlugin: workaround for dropdown in front of typing text with jQuery 1.7.x and Firefox (refs #12929)

[Jun Omae]

Replying to psuter:

Also TAB-key does not reopen dropdown anymore. ​Upstream issue filed.

I think the reopen after completion is good for source suggestion however it is not good for other strategies. Especially, newline would be unable to be entered when wiki processors is completed with enter key on {{{#!.

[Peter Suter]

In 15960:

WikiAutoCompletePlugin: Reopen menu after TAB-key.
Reverts a change in jquery-textcomplete, as suggested in ​https://github.com/yuku-t/jquery-textcomplete/issues/291
(see #12929)

[Peter Suter]

I think the reopen after completion is good for source suggestion

Right, very important there. So I reverted the behavior for the TAB key.

however it is not good for other strategies. Especially, newline would be unable to be entered when wiki processors is completed with enter key on {{{#!.

So we leave the ENTER key unchanged for now.

[Jun Omae]

Replying to psuter:

I think the reopen after completion is good for source suggestion

Right, very important there. So I reverted the behavior for the TAB key.

We could use adapter option without changing jquery-textcomplete.js.

wikiautocomplete/htdocs/js/wikiautocomplete.js

@@ -20 +20 @@
         return $.htmlEscape(text);
     }
 
+    var TextareaAdapter = $.fn.textcomplete.Textarea;
+    function Adapter(element, completer, option) {
+        this.initialize(element, completer, option);
+    }
+    $.extend(Adapter.prototype, TextareaAdapter.prototype, {
+        _skipSearchOrig: TextareaAdapter.prototype._skipSearch,
+        _skipSearch: function (clickEvent) {
+            if (clickEvent.keyCode === 9)
+                return;  // do not skip TAB key
+            return this._skipSearchOrig(clickEvent);
+        }
+    });
+
     $('textarea.wikitext').textcomplete([
         { // Attachment
             match: /\b((?:raw-)?attachment):(\S*)$/,
@@ -152 +165 @@
 
     ], {
         appendTo: $('body'),
+        adapter: Adapter,
         maxCount: 10000
     });
 

[Peter Suter]

We could use adapter option without changing jquery-textcomplete.js.

Nice!

[Jun Omae]

In 15964:

WikiAutoCompletePlugin: reopen menu after TAB-key using adapter option without the changes of jquery-textcomplete in [15960] (refs #12929)

[Jun Omae]

​v1.8.0 is released. I noticed search is triggered by page up/down and scroll position of dropdown is reset. The issue is fixed in v1.8.0.

[Peter Suter]

Ah, that's nice. I wondered why that happened.

[Jun Omae]

In 15967:

WikiAutoCompletePlugin: upgrade jquery-textcomplete from v1.7.3 to v1.8.0 (refs #12929)