set_owner_to_component_owner should check existence of selected component

[Jun Omae]

If set_owner_to_component_owner operation is used in workflow and component of the ticket is removed, auto-preview wouldn't work by 404 not found.

How to reproduce:

1. Use set_owenr_to_component_owner operation
2. Add blahblah to component
3. Create new ticket with component1
4. Visit the ticket
5. Remove blahblah component
6. Select blahblah component
7. Auto-preview receives 404 response and doesn't work

2017-03-08 19:25:32,842 Trac[main] WARNING: [192.168.11.21] HTTPNotFound: 404 Trac Error (Component blahblah does not exist.)

advancedworkflow/controller.py

@@ -16 +16 @@
 from trac.ticket.notification import TicketNotifyEmail
 from trac.resource import ResourceNotFound
 from trac.util.datefmt import utc
+from trac.util.text import to_unicode
 from trac.web.chrome import add_warning
 
 
@@ -126 +127 @@
 
     def _new_owner(self, ticket):
         """Determines the new owner"""
-        component = model.Component(self.env, name=ticket['component'])
-        self.env.log.debug("component %s, owner %s" % (component, component.owner))
-        return component.owner
+        try:
+            component = model.Component(self.env, name=ticket['component'])
+            return component.owner
+        except ResourceNotFound, e:
+            self.log.warning("In %s, %s", self._op_name, to_unicode(e))
+            return None
 
 
 class TicketWorkflowOpOwnerField(TicketWorkflowOpBase):

After the patch: owner of the ticket would be deleted if selected component isn't existent.

2017-03-08 19:38:46,993 Trac[controller] WARNING: In set_owner_to_component_owner, Component blahblah does not exist.

[Jun Omae]

reset_milestone operation has the same issue about milestone of the ticket.

advancedworkflow/controller.py

@@ -509 +509 @@
 
     def get_ticket_changes(self, req, ticket, action):
         """Returns the change of milestone, if needed."""
-        milestone = Milestone(self.env,ticket['milestone'])
-        if milestone.is_completed:
+        milestone = self._fetch_milestone(ticket)
+        if milestone and milestone.is_completed:
             return {'milestone': ''}
         return {}
+
+    def _fetch_milestone(self, ticket):
+        if ticket['milestone']:
+            try:
+                return Milestone(self.env, ticket['milestone'])
+            except ResourceNotFound, e:
+                self.log.warning("In %s, %s", self._op_name, to_unicode(e))
+        return None

[Jun Omae]

In 16306:

AdvancedTicketWorkflowPlugin/0.12: check existance of milestone and component in operations (closes #13104)