Modify ↓

Opened 6 years ago

Closed 6 years ago

#13361 closed defect (fixed)

Change lstrip parameter in childtickets.py

Reported by: anonymous Owned by: Ryan J Ollos
Priority: normal Component: ChildTicketsPlugin
Severity: normal Keywords:
Cc: qbi@… Trac Release: 1.2

Description

The Tor Project runs an trac instance. A user recently reported an error: ​https://trac.torproject.org/projects/tor/ticket/24744

The line 

pid = int(ticket.values.get('parent').lstrip('#'))

led to a traceback and the user suggested to change the line to: 

pid = int(ticket.values.get('parent').lstrip('$'))

Could you consider this change and maybe patch the plugin accordingly?

Thanks

Attachments (0)

Change History (2)

comment:1 Changed 6 years ago by Ryan J Ollos

Owner: changed from Mark Ryan to Ryan J Ollos
Status: new → accepted

I don't follow. Why is the user entering $24207 for a ticket id? Isn't that an invalid input for a parent ticket id?

I think we could at least raise an error that says "$24207 is an invalid ticket id".

comment:2 Changed 6 years ago by Ryan J Ollos

Resolution: → fixed
Status: accepted → closed

In 17042:

Tracchildtickets 2.5.5dev: Fix TypeError on invalid input

Fixes #13361.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.