AccountManager plugin does not work

[anonymous]

This diff against r9174, along with resolving the issues in #7974 and #7976, gets us an AccountManager plugin that will at least respond to password resets.

announce.py

@@ -79 +79 @@
         self._notify('verify', username, token=token)
 
     # IAnnouncementSubscriber interface
-    def subscriptions(self, event):
-        if event.realm == 'acct_mgr':
-            for subscriber in self._get_membership(event):
-                self.log.debug("AccountManagerAnnouncement added '%s " \
-                        "(%s)'", subscriber[1], subscriber[2])
-                yield subscriber
-
     def matches(self, event):
-        yield
+        if event.realm != 'acct_mgr':
+            return
+        
+        for subscriber in self._get_membership(event):
+            self.log.debug("AccountManagerAnnouncement added '%s " \
+                "(%s)'", subscriber[2], subscriber[3])
+            yield subscriber
 
     def description(self):
-        return 'notify me an account changes NOT IMPLEMENTED'
+        return
+
+    def requires_authentication(self):
+        return True
 
     # IAnnouncementFormatter interface
     def styles(self, transport, realm):
@@ -155 +157 @@
             for result in settings[event.category].get_subscriptions():
                 yield result
         elif event.category in ('verify', 'reset'):
-            yield ('email', event.username, True, None)
+            yield (self.__class__.__name__, 'email', event.username, True, None, 'text/plain', 1, 'always')
 
     def _format_plaintext(self, event):
         acct_templates = {

[anonymous]

Oh, I forgot to mention in the description that this also requires filter_exception_realms = acct_mgr in the [announcer] section of trac.ini or the announcements will just get filtered out if default filtering is enabled.

[Robert Corsaro]

Thanks. The accountmanager plugin definitely needs some love. I was hoping to get it started and have it taken over by someone else. I'll definitely show it some love in the coming months.

[Steffen Hoffmann]

Replying to doki_pen:

Thanks. The accountmanager plugin definitely needs some love. I was hoping to get it started and have it taken over by someone else. I'll definitely show it some love in the coming months.

Hm, seems like in reality it went quite the other way-round, right?

As a matter of fact after much work on AccountManagerPlugin I'm here to bring this plugin on level. Thanks for the report and substantial hints on how to fix this issue. After re-working parts of the database code it should be easy to resolve this issue. Thanks for your patience until then.

[Steffen Hoffmann]

(In [12309]) TracAnnouncer: Implement unused filter_exception_realms option, refs #7976 and #7977.

The chosen implementation should be slightly more efficient than what has been proposed in #7976, but I agree, that this is a pre-reqisite for making some subscribers effective, i.e. AccountManagerPlugin notifications.

[Steffen Hoffmann]

(In [12312]) TracAnnouncer: Update AccountManagerPlugin messaging support, refs #7759, #7977, #8740, #8927, #9090 and #9204.

This long-standing regression is fixed now, while associated message templates are rather bare-bone ones yet and formatting could be improved significantly.

[Steffen Hoffmann]

(In [12325]) TracAnnouncer: Fix generator, that was broken by [12309], refs #7759, #7976, #7977, #8740, #8927, #9090 and #9204.

And the same bad filter code even got replicated in [12312]. Sorry for not checking compiler errors earlier. Finally I discovered an UnboundLocalError for resource_id hidden behind the first error. Obviously unit tests are a blessing and needed here too.

[Steffen Hoffmann]

(In [12331]) TracAnnouncer: Really fix filter now, refs #7759, #7976, #7977, #8740, #8927, #9090 and #9204.

Complete the change from [12325] to get expected behavior, or filters would be applied undesirably.

[Steffen Hoffmann]

(In [12342]) TracAnnouncer: Add 'acct_mgr' as default for 'filter_exception_realms' option, refs #7759, #7976, #7977, #8740, #8927, #9090 and #9204.

IMHO this is required for better plugin usability, making AccountManagerPlugin notifications pass without additional configuration effort now.

Some Python doc-string tweaks and another unit test slipped in here too.

[Ryan J Ollos]

(In [12353]) Refs #7759, #7976, #7977, #8740, #8927, #9090 and #9204: Fixed minor syntax error introduced in [12342].

[Steffen Hoffmann]

(In [12503]) AnnouncerPlugin: Extend AccountManager notifications as required, refs #843, #7759 and #7977.

Note, that any previous version of TracAnnouncer won't work with latest AccountManagerPlugin 'trunk' code, and this already made me thinking about a more robust change listener definition. But this is another subject.