links to messages via anchors dont work

[Markus Decke]

Links of Messages which appear in the Timeline used to jump right to the message. Somehow the anchors are not used in the links anymore.

using the newest discussion plugin zip r10108 the links are now like this

https://<server>/discussion/message/1988

they were more like this

https://<server>/discussion/topic/131#message1988

Same behavior at ​http://blackhex.no-ip.org/timeline

The old way was nicer for long Threads and for linkage in the wiki

[Markus Decke]

I solved the problem with the diff of timeline, the right-hand side are my changes made to the latest original, as it looks in the svn.

79c79
<                 ids = ('message', message['id'])
---
>                 ids = (('topic',message['topic']),'message', message['id'])
86d85
< 
89,92c88,92
<            url = context.href.discussion(*ids)
<            if len(ids) == 3:
<                url = '%s#%s' % (url, ids[2])
<            return url
---
>             url = context.href.discussion(*ids)
>             if len(ids) == 3:
>                 url = context.href.discussion(*ids[0])
>                 url = '%s#%s%s' % (url, ids[1],ids[2])
>             return url
94c94
<            return tag(title)
---
>             return tag(title)
96c96
<            return tag(description)
---
>             return tag(description)

The last lines are not really changes, they just got moved to a different line. The problem was that the ids list never had 3 item, and therefor links were broken.

I used the ​zip provided at the discussionplugin wiki page.

I hope you can add that to the svn.

thx for the great plugin :)

[Markus Decke]

fix of the links to discussionboard in the timeline

[Radek Bartoň]

Thank you for the patch, I'll fix that in the trunk when I'll get back to the plugin develompment.

[Ryan J Ollos]

#8448 was closed as a duplicate.

[Markus Decke]

fixed with r12564 as in posted diff