Use configuration API instead of directly using `self.config.get()`.

[Jun Omae]

The plugin retrieves directly the configurations using self.config.get().

I think it should use ​configuration API instead. It would be able to edit the configuration via iniadmin.

blockdiagplugin/web_ui.py

@@ -8 +8 @@
 
 
 from trac.core import *
+from trac.config import Option
 from trac.wiki import IWikiMacroProvider
 from trac.web import IRequestHandler 
 from trac.wiki.formatter import system_message
@@ -104 +105 @@
         http://tk0miya.bitbucket.org/actdiag/build/html/index.html and http://tk0miya.bitbucket.org/nwdiag/build/html/index.html
     """
     implements (IWikiMacroProvider, IRequestHandler)
+
+    _default_type = Option('blockdiag', 'default_type', 'png',
+        doc="Default output format type which will be used when the type "
+            "isn't given.")
+
+    _font = Option('blockdiag', 'font', '',
+        doc="Path to a font file to draw a diagram.")
     
     macros = None
 
@@ -128 +136 @@
         if name[-4:] in ('_svg', '_png'):
             name, type = name.split('_')
         else:
-            type = (args.get('type') or self.env.config.get('blockdiag', 'default_type', 'png')).lower()
+            type = (args.get('type') or self._default_type).lower()
             if type not in ('svg', 'png'):
                 return system_message("Invalid type(%s). Type must be 'svg' or 'png'" % type)
                 
-        font = self.env.config.get('blockdiag', 'font', '')
+        font = self._font
 
         # nonascii unicode can't be passed to hashlib.
         id = make_hash('%s,%s,%s,%r' % (name, type, font, content)).hexdigest()

[iwata0303]

(In [10908]) see #9256 Use configuration API instead of direct access to Component.config.get (Thanks jun66j5)

[Ryan J Ollos]

Btw, I closed this because it looked like someone just forgot to do that, but please correct if I'm wrong.